Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ensure scroll to handle scrolling to a row properly #1379

Closed
wants to merge 2 commits into from
Closed

Update ensure scroll to handle scrolling to a row properly #1379

wants to merge 2 commits into from

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Jun 6, 2017

_focusOnNode handles both rows and cells, and in either case passes the object to _ensureScroll, but _ensureScroll just assumes that it will be dealing with a cell.

This would just update _ensureScroll to handle rows as well.

@maier49 maier49 requested a review from edhager June 6, 2017 16:16
@edhager edhager closed this in b5820d8 Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edhager edhager Awaiting requested review from edhager

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maier49