Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent notifications from causing a request for page 0 #1194

Closed
wants to merge 1 commit into from
Closed

Prevent notifications from causing a request for page 0 #1194

wants to merge 1 commit into from

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Oct 23, 2015

Fixes #1192 by ensuring that _onNotification never passes 0 to gotoPage

@kfranqueiro
Copy link
Member

Thanks for the fix + test! I updated the test to use public APIs by passing a store with one item, removing its item, then adding a new one. Merged to master (a3f64bc) and dev-0.4 (8b969fc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maier49 @kfranqueiro