fix dgrid horizontal scroll on focus #1086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When navigating with keyboard on a grid that is not wide enough to fit the entire grid, ensure that the column is scrolled in to view in entirety. Fixes issue in Chrome, Firefox, and Safari.
|
Please note that if the column is completely hidden, then the column will be scrolled into view automatically, without this fix. It's only if the column is partially showing where it doesn't in the browsers listed above. |
|
I've made amendments to this to improve behavior when adjusting to the right, to combine debounces, and to only execute this logic in cases where it's needed. I've got a branch ready against 0.3, but need to manually port to 0.4 / master before I merge it all. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating with keyboard on a grid that is not wide enough to fit
the entire grid, ensure that the column is scrolled in to view in
entirety. Fixes issue in Chrome, Firefox, and Safari.
This issue can be seen in this fiddle. Navigating with the keyboard, the rightmost column does not scroll all the way in to view in Chrome, Firefox, or Safari. It does in IE10/11.