Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnHider on OSX disappeared, with latest css changes #886

Closed
Ognian opened this issue Apr 3, 2014 · 0 comments
Closed

ColumnHider on OSX disappeared, with latest css changes #886

Ognian opened this issue Apr 3, 2014 · 0 comments

Comments

@Ognian
Copy link

Ognian commented Apr 3, 2014

Hi,

after applying commit: eeb6eaf
the ColumnHider icon disappears on OSX.
applying further until 0ff0a13 doesn't make it appear again.

on 0ff0a13 changing the below rule (disable overflow:hidden), makes the ColumnHider icon to appear again on OSX:

.dgrid-header, .dgrid-header-row, .dgrid-footer {
/* overflow: hidden; */
background-color: #eee;
}

I'm not sure if this is the right fix, it is only a difference I noticed wich made the ColumnHider icon appear again ...
Ognian

treasonx pushed a commit to treasonx/dgrid that referenced this issue Apr 4, 2014
We were adding the dgrid-header class to the headerScrollNode, which
will hide the ColumnHider icon on OSX browsers that hide the scrollbars
by default, because we set overflow:hidden in dgrid-header.

This is regression that appeared in v0.3.14, it was not present in
v0.3.13.
treasonx pushed a commit to treasonx/dgrid that referenced this issue Apr 9, 2014
…den.

When the scrollbars are hidden on OSX we want to add the ColumnHiderIcon
node as a child of the header node. On a platform that has scrollbars we
want to add the ColumnHiderIcon as a child of the headerScrollNode.

Also fixed a small IE11 bug which was causing us to fail to add
the dgrid-rtl-swap class to the table. This would result in a small
rendering bug for positioning the headerScrollNode properly.

Finally I added a test page for the column hider extension running on a
RTL page.
@ghost ghost closed this as completed in acb8b36 Apr 10, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant