Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent select handling between dgrid/Selection and dgrid/selector #822

Closed
msssk opened this issue Jan 25, 2014 · 0 comments
Closed

Comments

@msssk
Copy link
Contributor

msssk commented Jan 25, 2014

Open dgrid's test page:
dgrid/test/selector.html

In the 2nd grid ("A grid with radio selectors"):

  1. Click the 'Set selection mode to "none"' button
    1.1 Click an enabled radio button
    1.2 Click a disabled radio button => nothing happens; good
    1.3 Click a cell in a disabled row (not a cell in the selector column) => nothing happens; good
    1.4 Click a cell in the selector column in a disabled row => previously selected row is deselected; bad
  2. Click the 'Set selection mode to "single"' button
    2.1 Click an enabled radio button
    2.2 Click any cell in a disabled row => previously selected row is deselected; bad

Closely related, it seems like good UI design to have the dgrid/selector plugin handle all clicks in its column... meaning dgrid/Selection would have to not handle clicks in the selector column.

edhager added a commit to edhager/dgrid that referenced this issue Mar 28, 2014
edhager added a commit to edhager/dgrid that referenced this issue Mar 28, 2014
edhager added a commit to edhager/dgrid that referenced this issue Apr 1, 2014
…s and to move more functions into the prototype so they can be overridden. Also incorporated fixed for dojo#822.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant