New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectOnClick blocked by editor #704

Closed

jeff-ph opened this issue Aug 21, 2013 · 1 comment

jeff-ph commented Aug 21, 2013

When using an editor for a textbox widget (CurrencyTextBox in my case), the selectOnClick functionality is being prevented in editor.js due to the following code:

// XXX: stop mousedown propagation to prevent confusing Keyboard mixin logic
// with certain widgets; perhaps revising KB's `handledEvent` would be better.
on(node, "mousedown", function(evt){ evt.stopPropagation(); });

We've discovered that bypassing this code when the widget has selectOnClick allows the textbox selection to work as expected.

I have not been able to figure out a workaround for this, but would appreciate any suggestions.

kfranqueiro mentioned this issue

grid cell loses focus after apply edit(enter or escape) forcing user to use mouse instead of keyboard navigation #263

Closed

RichAyotte commented Sep 26, 2013

I was going to add an after advice that emitted a "mousdown" event to the editor's createEditor function as workaround but it's private so I'm not sure how to get to it from the outside. Any suggestions?

edhager added a commit to edhager/dgrid that referenced this issue


          Fixes dojo#704, removed the mousedown event listener from editor beca…

0fa906a

…use it was not allowing the selectOnClick for any TextBox based widget to be effective and I could not find any problems that listener was solving.

edhager closed this as completed in

799cfde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment