Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector column plugin is not working if columns are set after postCreate #533

Closed
betalb opened this issue Apr 8, 2013 · 1 comment
Closed

Comments

@betalb
Copy link

betalb commented Apr 8, 2013

If we set columns after postCreate, selector plugin won't work

The case is in function setupSelectionEvents, it wraps _initSelectionEvents with aspect, but this aspect won't fire in my case.

@k2s
Copy link
Contributor

k2s commented Apr 22, 2013

  • this makes it impossible to create dgrid with _WidgetsInTemplateMixin
  • _initSelectionEvents is fired in buildRendering()
  • but when column selector() is added to grid it hooks with aspect.before to initSelectionEvents which will never occure again
    • this code is never executed: this.on(".dgrid-selector:click,.dgrid-selector:keydown", onSelect);
    • and selection is not usable

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants