Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How do I prevent a row from getting selected on right click? #1354

Closed
kruthikavenkatathri opened this issue Feb 15, 2017 · 1 comment · Fixed by #1462
Closed

How do I prevent a row from getting selected on right click? #1354

kruthikavenkatathri opened this issue Feb 15, 2017 · 1 comment · Fixed by #1462

Comments

@kruthikavenkatathri
Copy link

No description provided.

msssk added a commit to msssk/dgrid that referenced this issue May 12, 2020
@msssk
Selection: ignore right mouse click
6ca5fc5 
When clicking a row or cell with the secondary mouse button it is not expected
that a selection event should occur. This change updates Selection.js to
ignore right mouse clicks.

Fixes dojo#1354
@msssk msssk mentioned this issue May 12, 2020
Merged
msssk added a commit that referenced this issue May 12, 2020
@msssk
Selection: ignore right mouse click
02b6750 
When clicking a row or cell with the secondary mouse button it is not expected
that a selection event should occur. This change updates Selection.js to
ignore right mouse clicks.

Fixes #1354
msssk added a commit that referenced this issue Jun 19, 2020
@msssk
Selection: ignore right mouse click
291bfae 
When clicking a row or cell with the secondary mouse button it is not expected
that a selection event should occur. This change updates Selection.js to
ignore right mouse clicks.

Fixes #1354
msssk added a commit that referenced this issue Jun 19, 2020
@msssk
Selection: ignore right mouse click
8d369a4 
When clicking a row or cell with the secondary mouse button it is not expected
that a selection event should occur. This change updates Selection.js to
ignore right mouse clicks.

Fixes #1354
@eQuorumRayNewman
Copy link

I disagree with this change. It broke our user's prior experience with our product. We present a context menu on selected items in a grid (behavior users are accustom to in Windows File Explorer for example). A right mouse click selects the item and presents a context menu for the item. With this release users must now right mouse click and then left mouse click to get the context menu. At a minimum the change should include a property to provide the desired behavior while retaining the previous behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Selection: ignore right mouse click msssk/dgrid
2 participants
@kruthikavenkatathri @eQuorumRayNewman