Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for #1211 #1237

Closed
kfranqueiro opened this issue Jan 6, 2016 · 0 comments
Closed

Add unit tests for #1211 #1237

kfranqueiro opened this issue Jan 6, 2016 · 0 comments
Assignees

Comments

@kfranqueiro
Copy link
Member

We've addressed the issues in #1211, and verified it manually, but given the complexity involved, it'd definitely be a good idea to have unit tests for the following:

  • check _editorCellListeners after invoking refreshCell (I'd suggest testing with Pagination so you can test with mixing in Pagination and Editor in either order to ensure inheritance works both ways)
  • check _editorCellListeners after modifying a store item that is within view
  • check _editorCellListeners after scrolling down in a long OnDemandList (set bodyNode.scrollTop) or after calling gotoPage in Pagination
maier49 added a commit to maier49/dgrid that referenced this issue Jan 7, 2016
maier49 added a commit that referenced this issue Jan 7, 2016
@maier49 maier49 closed this as completed in d7515c2 Jan 7, 2016
maier49 added a commit that referenced this issue Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants