Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Both deselect and select events are fired with extended selection mode #1011

Closed
savola28 opened this issue Sep 24, 2014 · 2 comments · Fixed by #1449
Closed

Both deselect and select events are fired with extended selection mode #1011

savola28 opened this issue Sep 24, 2014 · 2 comments · Fixed by #1449
Labels
bug

Comments

@savola28
Copy link

If selection mode is extended and I click row that is already selected row stays selected like it should be. However I noticed that both deselect and select events are fired for that row. This is because _extendedSelectionHandler first clears selection and then calls _multipleSelectionHandler which reselects the row. Is this a bug or a feature?
@gerpres
Copy link

gerpres commented Oct 31, 2016

any plans to tackle this issue?

@fkranenburg
Copy link

Please fix this.

@msssk msssk added the bug label Jan 16, 2020
msssk added a commit to msssk/dgrid that referenced this issue Jan 17, 2020
@msssk
Prevent unnecessary deselect/select when an already selected item is …
988b677 
…selected

Fixes dojo#1011
@msssk msssk mentioned this issue Jan 17, 2020
Merged
msssk added a commit that referenced this issue Apr 7, 2020
@msssk
Prevent unnecessary deselect/select when an already selected item is …
55f96bd 
…selected

Fixes #1011
msssk added a commit that referenced this issue Apr 18, 2020
@msssk
Prevent unnecessary deselect/select when an already selected item is …
1a24fa3 
…selected

Fixes #1011
msssk added a commit that referenced this issue Apr 18, 2020
@msssk
Prevent unnecessary deselect/select when an already selected item is …
1ecdf07 
…selected

Fixes #1011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent unnecessary deselect/select when an already selected item is selected msssk/dgrid
4 participants
@msssk @gerpres @savola28 @fkranenburg