Skip to content

Commit

Permalink
Selection: don't bother calling allowSelect for deselection
Browse files Browse the repository at this point in the history
This avoids an issue with resetting columns while something is selected;
it also short-circuits unnecessary logic, since if it's not possible to
select a row, it should always be deselected anyway.
  • Loading branch information
Kenneth G. Franqueiro committed Mar 5, 2013
1 parent 9a37a0c commit 5d6a2fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Selection.js
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ return declare(null, {
if(!row.element){
row = this.row(row);
}
if(this.allowSelect(row)){
if(!value || this.allowSelect(row)){
var selection = this.selection;
var previousValue = selection[row.id];
if(value === null){
Expand Down

0 comments on commit 5d6a2fd

Please sign in to comment.