Skip to content

Commit

Permalink
Fix #693: _StoreMixin: Run inherited newRow before removing noDataNode
Browse files Browse the repository at this point in the history
  • Loading branch information
Kenneth G. Franqueiro committed Aug 8, 2013
1 parent 16e9d7b commit 56d9de6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ This document outlines changes since 0.3.0. For older changelogs, see the
reference the correct path where intern-geezer installs to as of Intern 1.2.
* Fixed a regression in `_StoreMixin` (affecting `OnDemandList` and `Pagination`)
where setting `store` to `null` would cause an error. (#688, thanks kilink)
* Fixed a regression in `_StoreMixin` which caused an error when updating the
only row present in a list or grid. (#693)

### Extensions

Expand Down
5 changes: 4 additions & 1 deletion _StoreMixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,14 @@ function(kernel, declare, lang, Deferred, listen, aspect, put){

newRow: function(){
// Override to remove no data message when a new row appears.
// Run inherited logic first to prevent confusion due to noDataNode
// no longer being present as a sibling.
var row = this.inherited(arguments);
if(this.noDataNode){
put(this.noDataNode, "!");
delete this.noDataNode;
}
return this.inherited(arguments);
return row;
},
removeRow: function(rowElement, justCleanup){
var row = {element: rowElement};
Expand Down

0 comments on commit 56d9de6

Please sign in to comment.