You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the customAnimation function signature to include an index parameter, allowing users to apply custom animations based on the item’s index.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Could you resolve the conflicts and add a simple usage case for this change? For instance, a new demo to illustrate the scenario where this argument is needed. I would greatly appreciate it!
I've addressed these and added tests in another PR. I'll add credits for you, thanks! #735
<!-- Is this PR related to an open issue? -->
<!-- GitHub: Fixes #0, Relates to #1, etc. -->
### Description
<!-- Summary of changes and why if no corresponding issue -->
#709
### Review
- [ ] I self-reviewed this PR
<!-- Call out any changes that you'd like people to review or feedback on -->
### Testing
- [ ] I added/updated tests
- [ ] I manually tested
<!-- Describe any manual testing -->
Could you resolve the conflicts and add a simple usage case for this change? For instance, a new demo to illustrate the scenario where this argument is needed. I would greatly appreciate it!
I've addressed these and added tests in another PR. I'll add credits for you, thanks! #735
Sorry for the late response, and thank you for taking care of this!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dosubot
bot
added
the
size:XS
3000-2
changed the title
Description
This PR updates the customAnimation function signature to include an index parameter, allowing users to apply custom animations based on the item’s index.
Example
Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-10-23.at.21.43.34.mp4
Review