You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When endWithSpring is called, it is using the previous values for scrollEndVelocity and scrollEndTranslation (rather than the values just set in onGestureEnd). This seems to cause strange carousel behavior for the user: the function isn't using the values from the most recent pan.
From the user's standpoint, the problem is very obvious (and potentially frustrating) when the user pans one direction, then reverses direction for their next pan. (Please see video demonstration below.)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
For now, I'm explicitly leaving both the function parameter scrollEndVelocityValue and this local const velocity.
We could (should?) eliminate this line, though, and instead rename the function parameter to velocity instead.
nmassey
changed the title
fix: onGestureEnd -> endWithSpring uses outdated data via useSharedValue
fix: onGestureEnd -> endWithSpring uses outdated data via useSharedValueMar 25, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dosubot
bot
added
the
size:S
nmassey
changed the title
What: the bug
When
endWithSpringis called, it is using the previous values forscrollEndVelocityandscrollEndTranslation(rather than the values just set inonGestureEnd). This seems to cause strange carousel behavior for the user: the function isn't using the values from the most recent pan.From the user's standpoint, the problem is very obvious (and potentially frustrating) when the user pans one direction, then reverses direction for their next pan. (Please see video demonstration below.)
Why
This is due to updates to shared values created via
useSharedValue()updating asynchronously (see https://docs.swmansion.com/react-native-reanimated/docs/core/useSharedValue#remarks ).What: proposed fix
Rather than relying on the shared data variable between function calls, let's explicitly pass the values as arguments to
endWithSpring.May resolve the following issues
Screengrab video recordings
buggy behavior on
4.0.0-alpha.10(unpatched)Notice, panning the same direction works OK, but panning alternate direction fails.
Screen.Recording.2024-03-25.at.09.19.01.mov
improved behavior with patch
Screen.Recording.2024-03-25.at.09.24.18.mov