Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress gesture warning #480

Closed
wants to merge 1 commit into from
Closed

Conversation

PierreCapo
Copy link

@PierreCapo PierreCapo commented Oct 18, 2023

Current situation

Using the enabled property triggers a warning:

<Carousel
  enabled={false}
  width={100}
  height={100}
  data={myData}
  renderItem={({item}) => (
    // ... rendering items here
  )}
/>

image

Fix

Because GestureContainer can be a React.Fragment, passing a gesture prop in that scenarios triggers a warning. This commit ensures the gesture props is not passed in the scenario of a React.Fragment.

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

⚠️ No Changeset found

Latest commit: 5bfa8f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@PierreCapo PierreCapo changed the title fix: gesture warning fix: suppress gesture warning Oct 18, 2023
Because `GestureContainer` can be a React.Fragment, passing a `gesture` prop in that scenarios triggers a warning.
This commit ensures the `gesture` props is not passed in the scenario of a React.Fragment.
@dohooo
Copy link
Owner

dohooo commented Dec 3, 2023

Solved in #493, THX for your effort.

@dohooo dohooo closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants