-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Disable()
on handler configurers.
#289
Conversation
/cc @danilvpetrov FYI this will likely need some modifications to the static analysis code. |
Thinking some more about the static analysis side of things, I'm not sure we can even report the disabled status in any meaningful way, because Edit: I guess we could handle the case where |
After discussion with @danilvpetrov, we decided to change the When the config is constructed from an in-memory application the return value will always be either |
I've updated this PR to exclude any handlers that are disabled and otherwise unconfigured (i.e. no identity or routes) from application configurations. |
What change does this introduce?
This PR adds an
IsDisabled()
method to theHandler
andRichHandler
interfaces, the return value of which is driven by calls to theDisable()
method on Dogma's handler configurer interfaces (AggregateConfigurer
, etc).Why make this change?
I wanted to prototype this before merging dogmatiq/dogma#162
Is there anything you are unsure about?
I haven't looked into adding support for
Disable()
to the static analysis system.I also haven't added support to the interopspec config API.What issues does this relate to?