Manifest.json robots.txt #125
Conversation
freelancing-solutions
commented
Feb 15, 2021
freelancing-solutions
commented
- Added og:properties & twitter:cards
- Added manifest.json + icons
- Added service worker
- Added sitemap + robots.txt
| <meta content="width=device-width, initial-scale=1.0" name="viewport"> | ||
|
|
||
|
|
||
| <meta content="Getting Started with Dogecoin is as easy as 1, 2, 3! It's simple, easy to set up, and free." name="description"> |
index.html
Outdated
| @@ -13,11 +13,36 @@ | |||
| --> | |||
|
|
|||
| <!-- Meta --> | |||
| <title>Dogecoin</title> | |||
| <title>Dogecoin - #dogecoin - #doge</title> | |||
There was a problem hiding this comment.
I think we can keep the webiste universal and don't need to add hashtags here.
| <meta name="twitter:description" content="Dogecoin is an open source peer-to-peer digital currency, favored by Shiba Inus worldwide." /> | ||
| <meta name="twitter:domain" content='https://dogecoin.com' /> | ||
| <meta name="twitter:image" content="/imgs/doge-ogimage.png" /> | ||
| <meta name="twitter:image:alt" contect="dogecoin.com Shiba Inu" /> |
There was a problem hiding this comment.
A lot of these twitter attributes are duplicated and as far as I'm aware Twitter will work fine with most of them in the og namespace. So these should be reduced to only the missing ones.
There was a problem hiding this comment.
it is not apparent to me and i am not sure of the route twitter will take however i find that twitter
does indeed performs better with its own tags...the og: properties works best with Facebook and other platforms
the way things changes this days i would advice to keep both
index.html
Outdated
| <meta name="twitter:image" content="/imgs/doge-ogimage.png" /> | ||
| <meta name="twitter:image:alt" contect="dogecoin.com Shiba Inu" /> | ||
| <!--- favicon --> | ||
| <link rel="shortcut icon" href="../imgs/avatar.png" /> |
There was a problem hiding this comment.
Any reason for this using a relative path contrary to all the others?
There was a problem hiding this comment.
its wrong my mistake..
fixed relative path
| @@ -551,6 +578,13 @@ <h4 class="mobile-learn-padding" data-i18n="dgc-windows-wallet-modal-getting-sta | |||
| ); | |||
| </script> | |||
| <script src="/js/dogecoin.min.js"></script> | |||
| <script> | |||
| if('serviceWorker' in navigator) { | |||
There was a problem hiding this comment.
What is the reasoning behind a service worker? I'm not a webdev but for a simple static page it seems overkill?
There was a problem hiding this comment.
i am with the thought pattern that i can and will support adding more futures on dogecoin , such as forums and a blog
i already have code from other projects in python but i can not commit all the changes at the same time
however for now it seems you are right let me remove or comment out the service worker.
Commented out until needed,
This was my rationale
I have created a proposal which if successfull would mean we can upgrade dogecoin.com to using modern frameworks example react.js
see here -> #126
if this proposal ends up with support from others , we would eventually need a service worker, in order to support the added functionality
| { | ||
| var sParameterName = sURLVariables[i].split('='); | ||
| if (sParameterName[0] == sParam) | ||
| if (sParameterName[0] == sParam) |
There was a problem hiding this comment.
Changes in this file are note necessary.
There was a problem hiding this comment.
there was no changes , could have been an auto formated that line..
however its ok.
|
already implemented except there is a dire need for robots.txt as this site wont appear |
