-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to lit 3.0 #5080
Merged
Merged
Upgrade to lit 3.0 #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
chore
Repository/build/dependency maintenance
no-release-notes
Pull requests that should not show up in release notes
labels
Oct 25, 2023
jorg-vr
added
deploy naos
Request a deployment on naos
and removed
deploy naos
Request a deployment on naos
labels
Oct 25, 2023
jorg-vr
added
deploy naos
Request a deployment on naos
and removed
deploy naos
Request a deployment on naos
labels
Oct 25, 2023
jorg-vr
added
deploy naos
Request a deployment on naos
and removed
deploy naos
Request a deployment on naos
labels
Oct 25, 2023
jorg-vr
added
deploy naos
Request a deployment on naos
and removed
deploy naos
Request a deployment on naos
labels
Oct 25, 2023
jorg-vr
added
deploy naos
Request a deployment on naos
and removed
deploy naos
Request a deployment on naos
labels
Oct 25, 2023
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
October 25, 2023 15:11
chvp
approved these changes
Oct 26, 2023
bmesuere
removed
the
no-release-notes
Pull requests that should not show up in release notes
label
Oct 26, 2023
bmesuere
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces #5039
I took a different approach to support lit decorators:
compile using ts-loader (which uses the typescript compiler)
I also did some partially related changes:
@babel/preset-typescript
as it is no longer requiredStateProperty
decorator (otherwise production build was broken)Note
We still have @babel/plugin-transform-runtime which "is typically used only in development".
Also:
And we have
useBuiltIns: "entry"
. Maybe something to look into in the future, but too unrelated to fix here.Closes #5039
Closes #4960