Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to lit 3.0 #5080

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Upgrade to lit 3.0 #5080

merged 10 commits into from
Oct 26, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Oct 25, 2023

This pull request replaces #5039

I took a different approach to support lit decorators:
compile using ts-loader (which uses the typescript compiler)

I also did some partially related changes:

  • update typescript version to 5.2.2
  • fix a d3 typing error picked up by ts5.2
  • removed @babel/preset-typescript as it is no longer required
  • reviewed and removed a lot of babel plugins that are included in @babel/presets-env
  • moved types to production dependencies as they are required for build
  • fixed some imports from the more generic library (otherwise production build was broken)
  • only support typescript format for own StateProperty decorator (otherwise production build was broken)

Note

We still have @babel/plugin-transform-runtime which "is typically used only in development".

Also:

danger
When this plugin is enabled, the useBuiltIns option in @babel/preset-env must not be set. Otherwise, this plugin may not able to completely sandbox the environment.

And we have useBuiltIns: "entry". Maybe something to look into in the future, but too unrelated to fix here.

Closes #5039
Closes #4960

@jorg-vr jorg-vr added chore Repository/build/dependency maintenance no-release-notes Pull requests that should not show up in release notes labels Oct 25, 2023
@jorg-vr jorg-vr self-assigned this Oct 25, 2023
@jorg-vr jorg-vr added the deploy naos Request a deployment on naos label Oct 25, 2023
@jorg-vr jorg-vr added deploy naos Request a deployment on naos and removed deploy naos Request a deployment on naos labels Oct 25, 2023
@jorg-vr jorg-vr added deploy naos Request a deployment on naos and removed deploy naos Request a deployment on naos labels Oct 25, 2023
@jorg-vr jorg-vr added deploy naos Request a deployment on naos and removed deploy naos Request a deployment on naos labels Oct 25, 2023
@jorg-vr jorg-vr added deploy naos Request a deployment on naos and removed deploy naos Request a deployment on naos labels Oct 25, 2023
@jorg-vr jorg-vr added deploy naos Request a deployment on naos and removed deploy naos Request a deployment on naos labels Oct 25, 2023
@jorg-vr jorg-vr temporarily deployed to naos October 25, 2023 14:51 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy naos Request a deployment on naos label Oct 25, 2023
@jorg-vr jorg-vr marked this pull request as ready for review October 25, 2023 15:11
@jorg-vr jorg-vr requested a review from a team as a code owner October 25, 2023 15:11
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team October 25, 2023 15:11
@bmesuere bmesuere removed the no-release-notes Pull requests that should not show up in release notes label Oct 26, 2023
@bmesuere bmesuere changed the title Update to lit version 3.0 Upgrade to lit 3.0 Oct 26, 2023
@jorg-vr jorg-vr merged commit 1c1f907 into main Oct 26, 2023
12 of 13 checks passed
@jorg-vr jorg-vr deleted the chore/update-lit-3 branch October 26, 2023 14:36
@jorg-vr jorg-vr temporarily deployed to naos October 26, 2023 14:37 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production October 26, 2023 14:41 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository/build/dependency maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace @babel/plugin-proposal-object-rest-spread with @babel/plugin-transform-object-rest-spread
3 participants