Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Material 3 colors #3695

Merged
merged 33 commits into from
Jun 10, 2022
Merged

Implement Material 3 colors #3695

merged 33 commits into from
Jun 10, 2022

Conversation

bmesuere
Copy link
Member

@bmesuere bmesuere commented Jun 5, 2022

This pull request adapts the material 3 colors as described in here.

It uses the script from this script to generate all tones.

Changes

  • Replace the old colors file with a new one.
  • Change how we work with the bootstrap variables. Instead of reusing them in our code, we force our values to bootstrap and don't reuse them ourselves.
  • Removal of the development style. This wasn't used anymore and could be re-added later on if we have proper theme support.
  • The secondary color amber was replaced by pink. We don't use it a lot yet.

Advantages

  • We follow the spec. This also makes sure everything has proper contrast. This was not the case in the old design.
  • Greatly improved dark mode (instead of a home brewed one).
  • Preparation for switching to dark mode using css variables. This will also make it possible to have additional themes.
  • The variable files are a lot cleaner. The color file contains the raw color values, the theme file maps them to primary, secondary, info, etc. The theme-light and theme-dark files map them to semantic colors such as "background" or "on-background".

Screenshots

Home page

image
image

Exercise

image
image

Course

image
image

@bmesuere bmesuere force-pushed the feature/m3-colors branch 3 times, most recently from 8deba95 to 7598601 Compare June 6, 2022 12:17
@chvp chvp added the deploy mestra Request a deployment on mestra label Jun 6, 2022
@chvp chvp temporarily deployed to mestra June 6, 2022 16:20 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jun 6, 2022
@jorg-vr
Copy link
Contributor

jorg-vr commented Jun 7, 2022

image

Background color of flatpicker instances is gone

Base automatically changed from chore/scss-prettier to develop June 7, 2022 15:37
@bmesuere bmesuere force-pushed the feature/m3-colors branch from 81f0d99 to 94bccc4 Compare June 7, 2022 15:49
@bmesuere bmesuere changed the base branch from develop to feature/bootstrap-5.2 June 7, 2022 15:50
@bmesuere bmesuere changed the title Material 3 colors Implement Material 3 colors Jun 7, 2022
@bmesuere bmesuere added the feature New feature or request label Jun 7, 2022
@jorg-vr jorg-vr added the deploy mestra Request a deployment on mestra label Jun 8, 2022
@jorg-vr jorg-vr temporarily deployed to mestra June 8, 2022 07:29 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jun 8, 2022
@bmesuere
Copy link
Member Author

bmesuere commented Jun 9, 2022

  • token padding
  • find better "success" color (regenerate greens?) -> used teal
  • heatmap colors
  • dark mode code editor
  • dark mode about page
  • bg color of code blocks in dark mode
  • darker divider in dark mode
  • find solution for brownish secondary color in dark tones -> used pink instead of amber

@bmesuere bmesuere marked this pull request as ready for review June 9, 2022 16:53
@bmesuere bmesuere requested a review from a team as a code owner June 9, 2022 16:53
@bmesuere bmesuere requested review from niknetniko and chvp and removed request for a team June 9, 2022 16:53
@jorg-vr jorg-vr added the deploy mestra Request a deployment on mestra label Jun 9, 2022
@jorg-vr jorg-vr temporarily deployed to mestra June 9, 2022 16:59 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jun 9, 2022
@jorg-vr jorg-vr added the deploy mestra Request a deployment on mestra label Jun 10, 2022
@jorg-vr jorg-vr temporarily deployed to mestra June 10, 2022 07:14 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jun 10, 2022
app/assets/javascripts/heatmap.ts Show resolved Hide resolved
@bmesuere
Copy link
Member Author

I will merge this so we can continue without merge conflicts on other branches. Your comments are still welcome, @chvp and @niknetniko.

@bmesuere bmesuere merged commit 7f9a4ba into feature/bootstrap-5.2 Jun 10, 2022
@bmesuere bmesuere deleted the feature/m3-colors branch June 10, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants