-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimize js bundle sizes #3690
Merged
Merged
Minimize js bundle sizes #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 3 alerts when merging 9c7da8e into 923c1e2 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging f8b38f0 into 923c1e2 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 15d3e35 into 923c1e2 - view on LGTM.com new alerts:
|
bmesuere
approved these changes
Jun 2, 2022
chvp
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to minimize the javascript bundle sizes. Duplicate dependencies are merged into a common bundle.
Momentjs is replaced by dayjs, which allows for proper treeshaking.
This pr also adds webpack-bundle-analyzer as dev dependency to analyze webpack bundles.
It also contains a small refactor to use the utility method for flatpickr. (Which is no longer relevant for this pr, but improves the code)
Old
Total unminimized js size 4.85Mb
Transfered size from naos:
New
Total unminimized size 1.8Mb
Transfered size from naos:
Todo in future prs:
Closes #3667 .