Clear scores when another submission is selected to grade #3405
Conversation
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
chvp
changed the title
There was a problem hiding this comment.
I suppose this will also fix the issue reported in this comment?
db/seeds.rb
Outdated
| summary: submission_summary(status), | ||
| code: "print(input())\n", | ||
| result: File.read(Rails.root.join('db', 'results', "#{exercise.judge.name}-result.json")) | ||
| (1..rand(1..10)).each do |
There was a problem hiding this comment.
Do we really need this many submissions? I know this seems like a small number, but they quickly add up, especially in nested loops. After a while our tests and db seeds (and thus mestra deploys) become painfully slow.
There was a problem hiding this comment.
Created a separate course for visualizations. Because yes we need so many for decent graphs and testing features with multiple submission per student for example, but no need to have it in every course
db/seeds.rb
Outdated
| status: status, | ||
| accepted: status == :correct, | ||
| summary: submission_summary(status), | ||
| created_at: (Time.now - 1.day).beginning_of_day + 6.hour + rand(0..540).minutes + rand(0..540).minutes, |
There was a problem hiding this comment.
What is the goal if this construction? If there is a specific reason for this time range, maybe add a comment with the explanation.
Next to that, it can be cleaned up. The 6.hours and double rand can be replace by a single rand. The first part can probably be replaced by something like Date.yesterday or 1.day.ago.
There was a problem hiding this comment.
I improved the date and added a comment for the other part. Using two rands creates a bell curve, so it is not the same result as a single rand
This pull request clears the scores when an other submission is selected to grade.
Closes #3344 .