Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the amount of pixels of total score input on the grading page #3290

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Fix the amount of pixels of total score input on the grading page #3290

merged 1 commit into from
Jan 13, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jan 13, 2022

Before:
image

After:
image

Issue only happened on specific zoom levels because the input field had height 33.33px while the surrounding button-tags had height 33px

@jorg-vr jorg-vr added the bug Something isn't working label Jan 13, 2022
@jorg-vr jorg-vr self-assigned this Jan 13, 2022
@jorg-vr jorg-vr requested a review from a team as a code owner January 13, 2022 13:12
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team January 13, 2022 13:12
bmesuere
bmesuere approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure @toonijn will be very happy 😉

niknetniko
niknetniko approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@niknetniko niknetniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jorg-vr jorg-vr merged commit eef1479 into develop Jan 13, 2022
@jorg-vr jorg-vr deleted the fix/grading-total-input-pixel branch January 13, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorg-vr @bmesuere @niknetniko