Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make email address on user profiles a mailto link #3203

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Make email address on user profiles a mailto link #3203

merged 1 commit into from
Nov 19, 2021

Conversation

BTWS2
Copy link
Contributor

@BTWS2 BTWS2 commented Nov 13, 2021

image
image

Closes #3201.

@BTWS2 BTWS2 requested a review from a team as a code owner November 13, 2021 19:31
@BTWS2 BTWS2 requested review from bmesuere and chvp and removed request for a team November 13, 2021 19:31
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the tooltip is needed, but ok for me.

Thanks!

Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the issue asks, I would also add this to the user profile. For the Dodona admins, this can be useful as well.

@BTWS2 BTWS2 requested a review from chvp November 14, 2021 22:08
@chvp chvp added deploy mestra Request a deployment on mestra and removed deploy mestra Request a deployment on mestra labels Nov 15, 2021
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, the emailaddress is also colored as a link. Personally I think this is a bit too attention-grabbing, especially on the profile pages. @bmesuere opinions?

app/views/course_members/_members_table.html.erb Outdated Show resolved Hide resolved
@chvp chvp added the enhancement A change that isn't substantial enough to be called a feature label Nov 15, 2021
@chvp chvp changed the title Add mailto and tooltip Make email address on user profiles a mailto link Nov 15, 2021
app/views/users/show.html.erb Outdated Show resolved Hide resolved
@bmesuere
Copy link
Member

bmesuere commented Nov 15, 2021

Right now, the emailaddress is also colored as a link. Personally I think this is a bit too attention-grabbing, especially on the profile pages. @bmesuere opinions?

edit: adding the text-muted class is ok for me.

@BTWS2 BTWS2 requested a review from chvp November 15, 2021 21:43
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase on latest develop when making changes? That way the checks will run for your changes.

@@ -32,7 +32,7 @@
<%= link_to user.full_name, course_member_path(@course, user), title: user.full_name, class: "ellipsis-overflow" %>
<% end %>
</td>
<td><%= user.email %></td>
<td><%= mail_to(user.email, nil, {title: t('.send_mail'), class: 'text-muted'}) %></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fill in this nil argument, we have the name of the user (here and in the other instances). I would also not add the text-muted class here since the link works visually in our tables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced nil with the user email. I would like to continue displaying the e-mail, because not everyone has their mailto client configured properly. I removed text-muted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not realize filling in the argument would change the shown content of the a. In that case, leaving it empty seems like the better option. I'll change this, approve and merge.

@BTWS2
Copy link
Contributor Author

BTWS2 commented Nov 19, 2021

I had some trouble with the rebase because of multiple laptops, but it should be ok now.

@BTWS2 BTWS2 requested a review from chvp November 19, 2021 15:53
@chvp chvp merged commit 238e0a6 into dodona-edu:develop Nov 19, 2021
@BTWS2 BTWS2 deleted the mail-to branch November 19, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make email addresses on user profiles and course member pages a mailto link
4 participants