-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test performance #3052
Merged
Merged
Improve test performance #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total institutions created went from 2703 to 157 [TEST PROF INFO] Factories usage Total: 11343 Total top-level: 4276 Total time: 02:41.449 (out of 04:37.450) Total uniq factories: 37 total top-level total time time per call top-level time name 1535 62 10.4243s 0.0068s 0.4916s judge 1473 109 25.6807s 0.0174s 9.1480s repository 1458 435 7.9550s 0.0055s 2.2409s user 1293 11 2.5787s 0.0020s 0.0200s programming_language 1283 262 52.8969s 0.0412s 9.2936s exercise 806 806 53.3182s 0.0662s 53.3182s submission 592 155 53.8062s 0.0909s 12.5099s correct_submission 543 325 14.9243s 0.0275s 12.7668s course 496 496 2.2443s 0.0045s 2.2443s student 384 269 40.3077s 0.1050s 26.7965s series 381 381 1.6770s 0.0044s 1.6770s staff 280 280 1.2987s 0.0046s 1.2987s zeus 157 54 0.3056s 0.0019s 0.1023s institution 97 97 0.8352s 0.0086s 0.8352s question 90 90 0.9235s 0.0103s 0.9235s score_item 60 60 21.0340s 0.3506s 21.0340s evaluation 59 59 0.6514s 0.0110s 0.6514s score 48 48 3.3033s 0.0688s 3.3033s wrong_submission 42 15 0.5570s 0.0133s 0.2356s content_page 33 33 0.6919s 0.0210s 0.6919s activity_read_state 33 33 0.0729s 0.0022s 0.0729s identity 32 32 0.1560s 0.0049s 0.1560s provider 26 26 0.1411s 0.0054s 0.1411s annotation 18 18 0.1241s 0.0069s 0.1241s lti_provider 16 16 0.0876s 0.0055s 0.0876s smartschool_provider 16 16 0.0872s 0.0054s 0.0872s office365_provider 15 15 0.1081s 0.0072s 0.1081s api_token 15 15 0.0838s 0.0056s 0.0838s gsuite_provider 13 13 0.0808s 0.0062s 0.0808s saml_provider 11 11 0.0174s 0.0016s 0.0174s label 9 9 0.1696s 0.0188s 0.1696s rights_request 7 7 0.5408s 0.0773s 0.5408s course_submission 6 6 0.0242s 0.0040s 0.0242s temporary_user 5 1 0.0328s 0.0066s 0.0060s export 5 5 0.1128s 0.0226s 0.1128s evaluation_exercise 4 4 0.0424s 0.0106s 0.0424s notification 2 2 0.0126s 0.0063s 0.0126s activity_status
bmesuere
force-pushed
the
feature/faster-tests
branch
from
August 31, 2021 09:16
a156dd0
to
1c05c89
Compare
Total programming languages created went from 1293 to 11 Total: 10061 Total top-level: 4276 Total time: 02:58.203 (out of 05:00.185) Total uniq factories: 37 total top-level total time time per call top-level time name 1535 62 12.3575s 0.0081s 0.5157s judge 1473 109 29.4422s 0.0200s 9.7948s repository 1458 435 8.4758s 0.0058s 2.5445s user 1283 262 60.3953s 0.0471s 9.5759s exercise 806 806 61.6564s 0.0765s 61.6564s submission 592 155 57.4303s 0.0970s 13.4443s correct_submission 543 325 15.6532s 0.0288s 13.3003s course 496 496 2.2953s 0.0046s 2.2953s student 384 269 44.1073s 0.1149s 29.7707s series 381 381 1.7075s 0.0045s 1.7075s staff 280 280 1.4901s 0.0053s 1.4901s zeus 157 54 0.3344s 0.0021s 0.1278s institution 97 97 0.7426s 0.0077s 0.7426s question 90 90 0.9796s 0.0109s 0.9796s score_item 60 60 23.0017s 0.3834s 23.0017s evaluation 59 59 0.6801s 0.0115s 0.6801s score 48 48 3.5863s 0.0747s 3.5863s wrong_submission 42 15 0.5463s 0.0130s 0.2416s content_page 33 33 0.0818s 0.0025s 0.0818s identity 33 33 0.7324s 0.0222s 0.7324s activity_read_state 32 32 0.1969s 0.0062s 0.1969s provider 26 26 0.1562s 0.0060s 0.1562s annotation 18 18 0.1190s 0.0066s 0.1190s lti_provider 16 16 0.0944s 0.0059s 0.0944s smartschool_provider 16 16 0.0994s 0.0062s 0.0994s office365_provider 15 15 0.0927s 0.0062s 0.0927s gsuite_provider 15 15 0.1058s 0.0071s 0.1058s api_token 13 13 0.0771s 0.0059s 0.0771s saml_provider 11 11 0.0215s 0.0020s 0.0215s programming_language 11 11 0.0166s 0.0015s 0.0166s label 9 9 0.1759s 0.0195s 0.1759s rights_request 7 7 0.5734s 0.0819s 0.5734s course_submission 6 6 0.0257s 0.0043s 0.0257s temporary_user 5 1 0.0338s 0.0068s 0.0058s export 5 5 0.1214s 0.0243s 0.1214s evaluation_exercise 4 4 0.0403s 0.0101s 0.0403s notification 2 2 0.0120s 0.0060s 0.0120s activity_status
Total judge creations went from 1535 to 73 [TEST PROF INFO] Factories usage Total: 8599 Total top-level: 4270 Total time: 03:54.862 (out of 06:43.941) Total uniq factories: 37 total top-level total time time per call top-level time name 1473 109 24.3592s 0.0165s 11.2835s repository 1458 435 12.0872s 0.0083s 3.8035s user 1283 262 73.5874s 0.0574s 13.7818s exercise 806 806 71.1712s 0.0883s 71.1712s submission 592 155 83.8848s 0.1417s 19.8428s correct_submission 543 325 22.0437s 0.0406s 17.8401s course 496 496 3.3731s 0.0068s 3.3731s student 384 269 61.0696s 0.1590s 42.7817s series 381 381 2.5946s 0.0068s 2.5946s staff 280 280 2.1584s 0.0077s 2.1584s zeus 157 54 0.4005s 0.0026s 0.1364s institution 97 97 1.0500s 0.0108s 1.0500s question 90 90 1.5166s 0.0169s 1.5166s score_item 73 56 1.0448s 0.0143s 0.7232s judge 60 60 31.9354s 0.5323s 31.9354s evaluation 59 59 0.9784s 0.0166s 0.9784s score 48 48 5.7290s 0.1194s 5.7290s wrong_submission 42 15 0.8719s 0.0208s 0.3302s content_page 33 33 1.4321s 0.0434s 1.4321s activity_read_state 33 33 0.1128s 0.0034s 0.1128s identity 32 32 0.1947s 0.0061s 0.1947s provider 26 26 0.2237s 0.0086s 0.2237s annotation 18 18 0.1316s 0.0073s 0.1316s lti_provider 16 16 0.1104s 0.0069s 0.1104s smartschool_provider 16 16 0.1182s 0.0074s 0.1182s office365_provider 15 15 0.1127s 0.0075s 0.1127s api_token 15 15 0.1908s 0.0127s 0.1908s gsuite_provider 13 13 0.0995s 0.0077s 0.0995s saml_provider 11 11 0.0212s 0.0019s 0.0212s label 11 11 0.0399s 0.0036s 0.0399s programming_language 9 9 0.2052s 0.0228s 0.2052s rights_request 7 7 0.5774s 0.0825s 0.5774s course_submission 6 6 0.0429s 0.0072s 0.0429s temporary_user 5 5 0.1066s 0.0213s 0.1066s evaluation_exercise 5 1 0.0730s 0.0146s 0.0175s export 4 4 0.0827s 0.0207s 0.0827s notification 2 2 0.0127s 0.0064s 0.0127s activity_status
bmesuere
force-pushed
the
feature/faster-tests
branch
from
August 31, 2021 11:17
8c6635f
to
43d6f20
Compare
Total repo creations went from 1473 to 110 [TEST PROF INFO] Factories usage Total: 7236 Total top-level: 4270 Total time: 02:49.453 (out of 05:02.467) Total uniq factories: 37 total top-level total time time per call top-level time name 1458 435 8.9098s 0.0061s 2.4670s user 1283 262 49.6278s 0.0387s 7.7295s exercise 806 806 49.4764s 0.0614s 49.4764s submission 592 155 64.9395s 0.1097s 14.6166s correct_submission 543 325 15.7088s 0.0289s 12.9130s course 496 496 2.5864s 0.0052s 2.5864s student 384 269 44.1825s 0.1151s 31.5109s series 381 381 1.9889s 0.0052s 1.9889s staff 280 280 1.6451s 0.0059s 1.6451s zeus 157 54 0.3419s 0.0022s 0.1347s institution 110 109 9.2148s 0.0838s 9.2095s repository 97 97 0.8647s 0.0089s 0.8647s question 90 90 1.2293s 0.0137s 1.2293s score_item 73 56 0.7525s 0.0103s 0.6037s judge 60 60 24.0069s 0.4001s 24.0069s evaluation 59 59 0.8365s 0.0142s 0.8365s score 48 48 4.4368s 0.0924s 4.4368s wrong_submission 42 15 0.5212s 0.0124s 0.1424s content_page 33 33 1.1048s 0.0335s 1.1048s activity_read_state 33 33 0.0825s 0.0025s 0.0825s identity 32 32 0.1983s 0.0062s 0.1983s provider 26 26 0.1747s 0.0067s 0.1747s annotation 18 18 0.1188s 0.0066s 0.1188s lti_provider 16 16 0.0942s 0.0059s 0.0942s smartschool_provider 16 16 0.0981s 0.0061s 0.0981s office365_provider 15 15 0.0994s 0.0066s 0.0994s api_token 15 15 0.0889s 0.0059s 0.0889s gsuite_provider 13 13 0.0743s 0.0057s 0.0743s saml_provider 11 11 0.0270s 0.0025s 0.0270s programming_language 11 11 0.0217s 0.0020s 0.0217s label 9 9 0.1797s 0.0200s 0.1797s rights_request 7 7 0.5216s 0.0745s 0.5216s course_submission 6 6 0.0210s 0.0035s 0.0210s temporary_user 5 5 0.0685s 0.0137s 0.0685s evaluation_exercise 5 1 0.0580s 0.0116s 0.0198s export 4 4 0.0528s 0.0132s 0.0528s notification 2 2 0.0086s 0.0043s 0.0086s activity_status
bmesuere
force-pushed
the
feature/faster-tests
branch
from
August 31, 2021 12:42
7c25626
to
980608c
Compare
bmesuere
force-pushed
the
feature/faster-tests
branch
2 times, most recently
from
August 31, 2021 15:42
c6fd29a
to
381d345
Compare
bmesuere
force-pushed
the
feature/faster-tests
branch
from
August 31, 2021 16:02
381d345
to
208e109
Compare
bmesuere
force-pushed
the
feature/faster-tests
branch
from
August 31, 2021 18:02
de6d0f9
to
78b0bec
Compare
28 -> 14; 1.5s
9 -> 5; 1.5s
38 -> 10; 1.5s
12 -> 5; 1.5s
113 -> 70; 3s
82 -> 18; 2s
82 -> 18; 2s
265 -> 134; 20s repository stuff is slow
36 -> 19; 1.5s
62 -> 44; 24s
bmesuere
force-pushed
the
feature/faster-tests
branch
from
September 1, 2021 15:34
9ad5ef0
to
f5ead85
Compare
638 -> 74; 4s
135 -> 80; 3s
After going over the model tests, this is the result:
|
221 -> 95; 14.5s
bmesuere
force-pushed
the
feature/faster-tests
branch
from
September 2, 2021 08:24
5c1a2b1
to
eff4bb0
Compare
Final result
|
chvp
approved these changes
Sep 6, 2021
niknetniko
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to improve test performance.
Running test-prof shows that over half of the time is spent in factories. We will try to remedy this in several ways:
Before
After