List own courses first when copying a course #3049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimonDB
requested review from
bmesuere and
chvp
and removed request for
a team
chvp
requested changes
Aug 30, 2021
chvp
requested changes
Aug 30, 2021
Comment on lines
+32
to
+38
| @featured_courses = @courses.where(featured: true) | ||
| @own_courses = @courses.where(featured: false) | ||
| .reorder(year: :desc, name: :asc) | ||
| .select { |course| current_user.course_admin?(course) } | ||
| @other_courses = @courses.where(featured: false) | ||
| .reorder(year: :desc, name: :asc) | ||
| .reject { |course| current_user.course_admin?(course) } |
There was a problem hiding this comment.
Suggested change
| @featured_courses = @courses.where(featured: true) | |
| @own_courses = @courses.where(featured: false) | |
| .reorder(year: :desc, name: :asc) | |
| .select { |course| current_user.course_admin?(course) } | |
| @other_courses = @courses.where(featured: false) | |
| .reorder(year: :desc, name: :asc) | |
| .reject { |course| current_user.course_admin?(course) } | |
| featured_courses = @courses.where(featured: true) | |
| own_courses = @courses.where(featured: false) | |
| .reorder(year: :desc, name: :asc) | |
| .select { |course| current_user.course_admin?(course) } | |
| other_courses = @courses.where(featured: false) | |
| .reorder(year: :desc, name: :asc) | |
| .reject { |course| current_user.course_admin?(course) } | |
| @courses = featured_courses + own_courses + other_courses |
This way, no changes to the HTML are necessary. (Make sure to check this locally, I'm not entirely sure if the + works if the actual data hasn't been loaded yet.)
There was a problem hiding this comment.
This seems to result in an error:
It would be nice if that was possible because now there is a lot of redundant code in the HTML
There was a problem hiding this comment.
You can look at the server log to see the actual error. Probably an explicit load is necessary for the featured_courses.
chvp
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request lists the user's own courses (course admin) first in the course table when copying a course. To accomplish this, I split up the courses into 2 sets, one where the user is course admin of the courses and one where the user is not course admin.
Closes #1661.