Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the copy of the right request emails #2963

Merged
merged 4 commits into from
Aug 5, 2021

Conversation

bmesuere
Copy link
Member

@bmesuere bmesuere commented Aug 4, 2021

This pull request updates the copy of the right request emails.

The text is now a bit more customer focussed since this is one of the first contacts we have with teachers. In addition, I added links to the demo video and to our twitter and facebook accounts (in Dutch only).

@chvp if you're not ok with your name being in the emails, just let me know and I'll replace it with mine.

@bmesuere bmesuere added the enhancement A change that isn't substantial enough to be called a feature label Aug 4, 2021
@bmesuere bmesuere requested a review from a team as a code owner August 4, 2021 16:36
@bmesuere bmesuere requested review from niknetniko and chvp and removed request for a team August 4, 2021 16:36
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No personalized name for the reject?

app/views/rights_request_mailer/approved.en.html.erb Outdated Show resolved Hide resolved
app/views/rights_request_mailer/approved.nl.text.erb Outdated Show resolved Hide resolved
@bmesuere bmesuere requested a review from chvp August 4, 2021 16:53
@bmesuere bmesuere requested a review from niknetniko August 5, 2021 08:39
@bmesuere bmesuere merged commit 4e8701f into develop Aug 5, 2021
@bmesuere bmesuere deleted the feature/tweak-email-copy branch August 5, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants