Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ability to make score is more than maximum score when clicking next #2814

Closed
BTWS2 opened this issue Jun 4, 2021 · 2 comments · Fixed by #2959
Closed

Remove ability to make score is more than maximum score when clicking next #2814

BTWS2 opened this issue Jun 4, 2021 · 2 comments · Fixed by #2959
Labels
feature New feature or request high priority Things we want to see implemented soon student Things summer interns can do

Comments

@BTWS2
Copy link
Contributor

BTWS2 commented Jun 4, 2021

If you click NEXT when the total score is more than maximum score (25/4.5), Dodona does't give a warning.

image
@chvp chvp changed the title Add warning if total score is more than maximum score when clicking NEXT Add warning if total score is more than maximum score when clicking next Jun 4, 2021
@chvp chvp added medium priority Things we want to see implemented relatively soon student Things summer interns can do labels Jun 4, 2021
@chvp
Copy link
Member

chvp commented Jun 4, 2021

I think this is intended? IIRC, @pdawyndt wanted to be able to exceed the possible scores (similar as in Ufora).

@chvp chvp added the feature New feature or request label Jun 4, 2021
@chvp chvp added high priority Things we want to see implemented soon and removed medium priority Things we want to see implemented relatively soon labels Jul 6, 2021
@chvp chvp changed the title Add warning if total score is more than maximum score when clicking next Remove ability to make score is more than maximum score when clicking next Jul 6, 2021
@chvp
Copy link
Member

chvp commented Jul 6, 2021

We have not seen any use of the ability to exceed the limits, so we're just going to remove the ability to do that, since we don't have a clear usecase.

@chvp chvp mentioned this issue Aug 4, 2021
Merged
1 task
@chvp chvp closed this as completed in #2959 Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request high priority Things we want to see implemented soon student Things summer interns can do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't allow out of bounds values when grading dodona-edu/dodona
2 participants
@chvp @BTWS2