Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow out of bounds values when grading #2959

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Don't allow out of bounds values when grading #2959

merged 2 commits into from
Aug 4, 2021

Conversation

chvp
Copy link
Member

@chvp chvp commented Aug 4, 2021 •
edited
Loading

This pull request removes the ability to enter out of bounds values when grading.

  • Tests were added

Closes #2814.

@chvp chvp added the enhancement A change that isn't substantial enough to be called a feature label Aug 4, 2021
@chvp chvp force-pushed the fix/no-out-of-bounds-values branch from 0180e5f to aed2692 Compare August 4, 2021 11:52
@chvp chvp marked this pull request as ready for review August 4, 2021 11:57
@chvp chvp requested a review from a team as a code owner August 4, 2021 11:57
@chvp chvp requested review from bmesuere and niknetniko and removed request for a team August 4, 2021 11:57
@chvp chvp merged commit 10e0992 into develop Aug 4, 2021
@chvp chvp deleted the fix/no-out-of-bounds-values branch August 4, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees
No one assigned
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ability to make score is more than maximum score when clicking next
3 participants
@chvp @bmesuere @niknetniko