Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight prompt in dark mode #2778

Closed
pdawyndt opened this issue May 27, 2021 · 6 comments · Fixed by #2947
Closed

Highlight prompt in dark mode #2778

pdawyndt opened this issue May 27, 2021 · 6 comments · Fixed by #2947
Assignees
@TimonDB
Labels
bug Something isn't working low priority Thing we want to see implemented at some point student Things summer interns can do

Comments

@pdawyndt
Copy link
Contributor

In highlighted code in exercise descriptions, prompts only get a distinct color in white mode, not in dark mode.
@bmesuere bmesuere added student Things summer interns can do low priority Thing we want to see implemented at some point labels Jun 3, 2021
@chvp
Copy link
Member

chvp commented Jun 5, 2021

Can you add a screenshot?

@chvp chvp added the bug Something isn't working label Jun 5, 2021
@pdawyndt
Copy link
Contributor Author

pdawyndt commented Jun 5, 2021 •
edited
Loading

Example: https://dodona.ugent.be/en/courses/453/series/6914/activities/747849983/

image

image

@bmesuere
Copy link
Member

bmesuere commented Jun 5, 2021

The syntax highlighting colors are done by a separate css file and were not touched in the bootstrap migration. Are you sure this was different before?

@pdawyndt
Copy link
Contributor Author

pdawyndt commented Jun 5, 2021

No, not sure.

@TimonDB
Copy link
Contributor

TimonDB commented Aug 2, 2021 •
edited
Loading

Similar to #2411, prompts get also a distinct colour in dark mode. However, this colour is #f8f8f2 which is the same as the other text. Should this prompt colour in dark mode be adapted or can this issue be closed?

rouge-dark.css.scss
Screenshot from 2021-08-02 17-05-13

@bmesuere
Copy link
Member

bmesuere commented Aug 2, 2021

Replacing #f8f8f2 with something more prominent seems the way to go. You should probably pick a color that's already used in the rouge-dark file so we keep using the same theme.

@TimonDB TimonDB mentioned this issue Aug 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimonDB TimonDB

Labels
bug Something isn't working low priority Thing we want to see implemented at some point student Things summer interns can do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt prompt colour in dark mode dodona-edu/dodona
4 participants
@bmesuere @pdawyndt @chvp @TimonDB