Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing highlighting of numbers in light mode #2411

Closed
pdawyndt opened this issue Dec 2, 2020 · 3 comments
Closed

Missing highlighting of numbers in light mode #2411

pdawyndt opened this issue Dec 2, 2020 · 3 comments
Assignees
Labels
bug Something isn't working low priority Thing we want to see implemented at some point student Things summer interns can do wontfix This will not be worked on

Comments

@pdawyndt
Copy link
Contributor

pdawyndt commented Dec 2, 2020

The class="mi" causes numbers in code blocks to be highlighted in dark mode

image

but not in light mode

image

@bmesuere bmesuere added student Things summer interns can do low priority Thing we want to see implemented at some point labels Apr 12, 2021
@chvp chvp added the bug Something isn't working label Jun 5, 2021
@TimonDB
Copy link
Contributor

TimonDB commented Aug 2, 2021

At the moment, numbers in light mode are grey (#666666). Would it be best to change this to the same colour as dark mode (purple, #bd93f9) or would it be better to use another colour?

Currently:
Screenshot from 2021-08-02 16-40-07

In purple:
Screenshot from 2021-08-02 16-39-33

@bmesuere
Copy link
Member

bmesuere commented Aug 2, 2021

If they are currently gray as shown in the top screenshot, this is an invalid issue and can be closed.

@TimonDB
Copy link
Contributor

TimonDB commented Aug 2, 2021

They are indeed grey, the class=mi uses this colour for highlighting numbers in light mode. I will close this issue in that case.

@TimonDB TimonDB closed this as completed Aug 2, 2021
@bmesuere bmesuere added the wontfix This will not be worked on label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority Thing we want to see implemented at some point student Things summer interns can do wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants