Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile menu following anchor clicks #713

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

Glazy
Copy link
Contributor

@Glazy Glazy commented Mar 24, 2019

Description

Resolves: #495

whenever a user clicked an anchor link with the mobile menu open it
would cause the mobile menu to re-position itself to half-way off the
page

Review

  • Open mobile menu and click on an anchor link

Screenshots

Before After
Screenshot 2019-03-24 at 15 31 08

whenever a user clicked an anchor link with the mobile menu open it
would cause the mobile menu to re-position itself to half-way off the
page
@pedronauck pedronauck merged commit e3bbf1a into doczjs:dev Mar 26, 2019
@Glazy Glazy deleted the fix/mobile-menu-positioning branch March 26, 2019 21:06
pedronauck added a commit that referenced this pull request Mar 29, 2019
* 'dev' of github.com:pedronauck/docz:
  fix(docz-core): entries not initialized on build (#725)
  fix(docz-theme-default): apply ignore in props parsing (#723)
  chore(docz-theme-default): search icon and sidebar top border. (#721)
  chore(docz-theme-default): export enhance from docz-theme-default (#715)
  fix(docz-theme-default): stop nested ul from rendering flat (#714)
  fix(docz-theme-default): mobile menu following anchor clicks (#713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants