Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Node v4 support #873

Closed
tmcw opened this issue Aug 11, 2017 · 0 comments
Closed

Fix Node v4 support #873

tmcw opened this issue Aug 11, 2017 · 0 comments
Assignees
@tmcw
Labels
bug

Comments

@tmcw
Copy link
Member

tmcw commented Aug 11, 2017

#871 introduced parameter default syntax but our babel configuration does not transpile that syntax.
@tmcw tmcw added the bug label Aug 11, 2017
@tmcw tmcw self-assigned this Aug 11, 2017
tmcw added a commit that referenced this issue Aug 11, 2017
@tmcw
fix: Fix node v4 support by using babel-preset-env
d3f381f 
Fixes #873
@tmcw tmcw mentioned this issue Aug 11, 2017
Closed
tmcw added a commit that referenced this issue Aug 11, 2017
@tmcw
style: Avoid optional parameter syntax
30d12db 
Supporting this syntax uncorks a whole bottle of worms and requires participation in more of the
JavaScript ecosystem and is not worthwhile in my opinion at this time.

Fixes #873
@tmcw tmcw mentioned this issue Aug 11, 2017
Merged
@tmcw tmcw closed this as completed in #876 Aug 12, 2017
tmcw added a commit that referenced this issue Aug 12, 2017
@tmcw
style: Avoid optional parameter syntax
e0b605f 
Supporting this syntax uncorks a whole bottle of worms and requires participation in more of the
JavaScript ecosystem and is not worthwhile in my opinion at this time.

Fixes #873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcw tmcw

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmcw