Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation not honoring flow typing #1043

Closed
ilias-t opened this issue Apr 10, 2018 · 2 comments
Closed

Documentation not honoring flow typing #1043

ilias-t opened this issue Apr 10, 2018 · 2 comments

Comments

@ilias-t
Copy link

ilias-t commented Apr 10, 2018 •
edited
Loading

Here's the generated docs: http://iliastsangaris.com/rawjs/

And here's an example file in the source code: https://github.com/ilias-t/rawjs/blob/master/src/LinkedList/index.js

Not sure why the docs aren't honoring any of the flow annotations.
@celicoo
Copy link

celicoo commented Apr 11, 2018

Same issue here.

@tmcw
Copy link
Member

tmcw commented Apr 11, 2018

My suspicion is that this example code is using the class properties transform, and we don't yet parse that AST variety.

tmcw added a commit that referenced this issue Apr 11, 2018
@tmcw
feat(inferTypes): Support class properties
1fcc4ec 
Previously we did not properly infer params on methods that were located on class properties. This
changes things so that we do. It carefully tries to avoid messing up the existing support of class
type annotations, which are similar to class properties at the AST level, but do not have an
associated node, only a type alias.

Fixes #1043
@tmcw tmcw mentioned this issue Apr 11, 2018
Merged
tmcw added a commit that referenced this issue Apr 11, 2018
@tmcw
feat(inferTypes): Support class properties
22d8740 
Previously we did not properly infer params on methods that were located on class properties. This
changes things so that we do. It carefully tries to avoid messing up the existing support of class
type annotations, which are similar to class properties at the AST level, but do not have an
associated node, only a type alias.

Fixes #1043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmcw @ilias-t @celicoo