Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi reference same file #276

Open
wants to merge 4 commits into
base: 0.5.x
Choose a base branch
from
Open

Multi reference same file #276

wants to merge 4 commits into from

Conversation

alamirault
Copy link

Try fix #275

When a ref is in a included file which is used multiple time, generated anchor it's always the same and not the best.

greg0ire
greg0ire reviewed Jan 14, 2024
View reviewed changes
tests/MultipleIncludeReference/BuilderTest.php
$contents
);

$expected = '<p>Reference is <a href="page2.html#reference-one">here</a></p>';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone wondering, the bug is that without @alamirault 's changes, instead of page2.html, page1.html is used.

@greg0ire
Copy link
Member

It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those.

@alamirault
Copy link
Author

@greg0ire I fixed code style, pipeline should be green now

SenseException
SenseException approved these changes Jan 28, 2024
View reviewed changes
tests/MultipleIncludeReference/input/include-in-many-files.inc
.. _reference-one:

``one``
~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that GitHub highlights a missing newline at the end of a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@weaverryan weaverryan Awaiting requested review from weaverryan

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better anchor URL for include reference
3 participants
@alamirault @greg0ire @SenseException