Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Cannot find column for index "0"' on TableNode rowspan #273

Draft
wants to merge 1 commit into
base: 0.5.x
Choose a base branch
from

Conversation

SenseException
Copy link
Member

This is is referencing the issue of doctrine/doctrine-website#476 (comment) that is blocking the last steps of the PR doctrine/doctrine-website#476. It's also mentioned and described in doctrine/dbal#3338 (comment).

The first commit contains rst and html files for a failing test.

@SenseException
Copy link
Member Author

@weaverryan I was looking through the code of the TableNode class and I don't have the impression that this table could be accomplished with the current rowspan handling in compilePrettyTable(). Maybe you have an idea if this can be done with the current code because of the major changes you did a few years ago?

@weaverryan
Copy link
Collaborator

@SenseException I don't have any idea, sorry - it's just been too long since I worked on that code. My rewrite was largely to try to take the old code, which was even more of a mess, and refactor it to be a bit more readable and meaningful. But 4 years later, I'm afraid I won't be much help

@SenseException
Copy link
Member Author

Thanks for taking a look at this. I currently see that another rewrite would be needed to get the expected rowspan for this use case 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants