Describe some types more accurately #183
Conversation
greg0ire
force-pushed
the
improve-return-type
branch
2 times, most recently
from
e662316 to
05c99b3
Compare
| @@ -136,7 +136,9 @@ public function getAllClassNames($globalBasename) | |||
| } | |||
|
|
|||
| // NOTE: All files found here means classes are not transient! | |||
| $classes[] = str_replace('.', '\\', $fileName); | |||
| /** @psalm-var class-string */ | |||
There was a problem hiding this comment.
Using assert(class_exists($class)) on this particular one makes the ORM test suite fail https://github.com/doctrine/orm/blob/2.8.x/tests/Doctrine/Tests/ORM/Tools/ConvertDoctrine1SchemaTest.php because there is heavy mocking involved.
|
@orklah @franmomu please review. More things could be done if it were not for vimeo/psalm#5788 |
greg0ire
force-pushed
the
improve-return-type
branch
2 times, most recently
from
3bb0d6a to
580729e
Compare
|
I think a good amount of the arrays could be described as |
greg0ire
force-pushed
the
improve-return-type
branch
3 times, most recently
from
c8fd4c9 to
87daf16
Compare
| @@ -13,6 +13,7 @@ interface MappingDriver | |||
| * Loads the metadata for the specified class into the provided container. | |||
| * | |||
| * @param string $className | |||
| * @psalm-param class-string $className | |||
There was a problem hiding this comment.
I guess here @template T of object could be used to specify class-string<T> and ClassMetadata<T>.
There was a problem hiding this comment.
Oh right, fixed, thanks!
There was a problem hiding this comment.
I don't really understand how I can fix the resulting error, maybe I should ignore it…
There was a problem hiding this comment.
hmmm I guess so, what I don't know is why it didn't complain calling object::loadMetadata 🤔
greg0ire
force-pushed
the
improve-return-type
branch
from
87daf16 to
c655f60
Compare
Downstream builds are broken because the last release of persistence describes its inputs more accurately, but not its outputs.
greg0ire
force-pushed
the
improve-return-type
branch
from
c655f60 to
c62177e
Compare
|
Thanks @greg0ire! |
Downstream builds are broken partly because the last release of persistence
describes its inputs more accurately, but not its outputs.