Define Proxy as generic
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Apr 3, 2021
|
@franmomu maybe this can be improved? |
franmomu
commented
Apr 3, 2021
| @@ -485,14 +489,21 @@ private function getRealClass(string $class): string | |||
| private function createDefaultProxyClassNameResolver(): void | |||
| { | |||
| $this->proxyClassNameResolver = new class implements ProxyClassNameResolver { | |||
| /** | |||
| * @template T of object | |||
| * @psalm-param class-string<Proxy<T>>|class-string<T> $className | |||
There was a problem hiding this comment.
I've copied this because otherwise the /** @psalm-var class-string<T> */ won't recognise the T.
There was a problem hiding this comment.
Seems like this is not enough, the tests are still failing
There was a problem hiding this comment.
Apparently it should work, I'll ignore for now.
VincentLanglet
approved these changes
Apr 5, 2021
|
Thanks @franmomu ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow things like doctrine/common#926