Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class-string typehint for getAssociationTargetClass #163

Merged
merged 3 commits into from
Apr 5, 2021
Merged

Add class-string typehint for getAssociationTargetClass #163

merged 3 commits into from
Apr 5, 2021

Conversation

VincentLanglet
Copy link
Contributor

No description provided.

@VincentLanglet
Copy link
Contributor Author

Friendly ping @greg0ire :)

@greg0ire
Copy link
Member

greg0ire commented Apr 5, 2021

🤔 why are you targeting 2.1.x ?

@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Apr 5, 2021

🤔 why are you targeting 2.1.x ?

It was the default branch, and I don't know the rules about the phpdoc.
It can be considered as a patch, because it will fix some developper psalm issues.

You prefer 2.2.x ?

@greg0ire
Copy link
Member

greg0ire commented Apr 5, 2021

I think 2.2.x is appropriate indeed 👍 . Your proposal is more precise, but string was not wrong either.

@VincentLanglet VincentLanglet changed the base branch from 2.1.x to 2.2.x April 5, 2021 15:10
@VincentLanglet
Copy link
Contributor Author

Done

@greg0ire greg0ire merged commit 9d18f25 into doctrine:2.2.x Apr 5, 2021
@greg0ire
Copy link
Member

greg0ire commented Apr 5, 2021

Thanks @VincentLanglet !

@VincentLanglet VincentLanglet deleted the patch-2 branch April 5, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants