Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Psalm level to 3 and add generics to ClassMetadata #159

Closed
wants to merge 13 commits into from
Closed

Raise Psalm level to 3 and add generics to ClassMetadata #159

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9a56cc0
Use class string arguments
franmomu Feb 14, 2021
16e8615
Use class string annotation
franmomu Feb 14, 2021
01707f5
Fix possible false argument
franmomu Feb 14, 2021
5a5e6a3
Fix some phpdoc
franmomu Feb 14, 2021
d8c5f79
Extract method to get class string variable
franmomu Feb 14, 2021
6b24d36
Raise psalm level to 3
franmomu Feb 14, 2021
4eab605
Add generics to ClassMetadata
franmomu Feb 14, 2021
5893ad2
Fix psalm issues
franmomu Apr 2, 2021
54d344b
Use a more specific value type
franmomu Apr 6, 2021
8e6fc2f
Explain psalm ignored errors
franmomu Apr 6, 2021
a067fdf
Make explicit param types
franmomu Apr 6, 2021
07ed4b6
Use real classes for tests
franmomu Apr 6, 2021
df82d13
Use ::class instead of string
franmomu Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions psalm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,21 @@
</NullArgument>
<PossiblyNullReference>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave a comment to explain why those couldn't be fixed and had to be ignored? It will be helpful for future contributions

<errorLevel type="suppress">
<!-- ReflectionProperty::getType() can return null, but there is ReflectionProperty::hasType()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed in Psalm recently:
vimeo/psalm#5258
Maybe Psalm can be upgraded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is ReflectionProperty (instead of ReflectionParameter) I've created vimeo/psalm#5584 based on vimeo/psalm#5258, but after reading it again, IIUC, it won't work because ReflectionProperty is not immutable.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my mistake then :)

check before -->
<file name="lib/Doctrine/Persistence/Reflection/TypedNoDefaultReflectionProperty.php"/>
</errorLevel>
</PossiblyNullReference>
<ArgumentTypeCoercion>
<errorLevel type="suppress">
<!-- On purpose to use a non existing class for tests -->
<referencedFunction name="RuntimeReflectionServiceTest::testGetParentClassesForAbsentClass"/>
<file name="tests/Doctrine/Tests/Persistence/Mapping/RuntimeReflectionServiceTest.php"/>
</errorLevel>
</ArgumentTypeCoercion>
<MoreSpecificReturnType>
<errorLevel type="suppress">
<!-- FileDriver::loadMappingFile() in tests could have a more specific return, but is not needed -->
<file name="tests/Doctrine/Tests/Persistence/Mapping/FileDriverTest.php"/>
</errorLevel>
</MoreSpecificReturnType>
Expand Down