Raise Psalm to level 3

This includes:
  - adding assertions to avoid nullable values
  - Override phpdoc to be more specific

Apart from ignore some issues.

lib/Doctrine/Persistence/Mapping/AbstractClassMetadataFactory.php

@@ -17,6 +17,7 @@
 use function array_map;
 use function array_reverse;
 use function array_unshift;
+use function assert;
 use function explode;
 use function sprintf;
 use function str_replace;
@@ -498,6 +499,8 @@ private function getRealClass(string $class): string
             $this->createDefaultProxyClassNameResolver();
         }
 
+        assert($this->proxyClassNameResolver !== null);
+
         return $this->proxyClassNameResolver->resolveClassName($class);
     }
 

lib/Doctrine/Persistence/Mapping/MappingException.php

@@ -50,7 +50,7 @@ public static function fileMappingDriversRequireConfiguredDirectoryPath($path =
         return new self(sprintf(
             'File mapping drivers must have a valid directory path, ' .
             'however the given path %s seems to be incorrect!',
-            $path
+            (string) $path
         ));
     }
 

lib/Doctrine/Persistence/Mapping/RuntimeReflectionService.php

@@ -61,7 +61,10 @@ public function getClassNamespace($class)
     }
 
     /**
-     * {@inheritDoc}
+     * @param string $class
+     * @psalm-param class-string $class
+     *
+     * @return ReflectionClass
      */
     public function getClass($class)
     {

lib/Doctrine/Persistence/Reflection/TypedNoDefaultReflectionProperty.php

@@ -2,8 +2,11 @@
 
 namespace Doctrine\Persistence\Reflection;
 
+use Closure;
 use ReflectionProperty;
 
+use function assert;
+
 /**
  * PHP Typed No Default Reflection Property - special override for typed properties without a default value.
  */
@@ -38,6 +41,9 @@ public function setValue($object, $value = null)
                 unset($this->$propertyName);
             };
             $unsetter = $unsetter->bindTo($object, $this->getDeclaringClass()->getName());
+
+            assert($unsetter instanceof Closure);
+
             $unsetter();
 
             return;

psalm.xml

@@ -1,8 +1,7 @@
 <?xml version="1.0"?>
 <psalm
-    totallyTyped="false"
-    errorLevel="4"
-    resolveFromConfigFile="true"
+    errorLevel="3"
+    findUnusedPsalmSuppress="true"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
@@ -39,5 +38,17 @@
                 <file name="tests/Doctrine/Tests/Persistence/Mapping/SymfonyFileLocatorTest.php"/>
             </errorLevel>
         </NullArgument>
+        <ArgumentTypeCoercion>
+            <errorLevel type="suppress">
+                <!-- On purpose to use a non existing class for tests -->
+                <file name="tests/Doctrine/Tests/Persistence/Mapping/RuntimeReflectionServiceTest.php"/>
+            </errorLevel>
+        </ArgumentTypeCoercion>
+        <MoreSpecificReturnType>
+            <errorLevel type="suppress">
+                <!-- FileDriver::loadMappingFile() in tests could have a more specific return, but is not needed -->
+                <file name="tests/Doctrine/Tests/Persistence/Mapping/FileDriverTest.php"/>
+            </errorLevel>
+        </MoreSpecificReturnType>
     </issueHandlers>
 </psalm>

tests/Doctrine/Tests/Persistence/ObjectManagerDecoratorTest.php

@@ -22,7 +22,7 @@ public function __construct(ObjectManager $wrapped)
 
 class ObjectManagerDecoratorTest extends TestCase
 {
-    /** @var MockObject|ObjectManager */
+    /** @var MockObject&ObjectManager */
     private $wrapped;
 
     /** @var NullObjectManagerDecorator */