Support native enum hydration when using NEW operator
#9936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romm
force-pushed
the
fix/enum-new-operator
branch
from
02e054a to
015cae5
Compare
SenseException
requested changes
Jul 28, 2022
Comment on lines
136
to
166
| $result = $this->_em->createQueryBuilder() | ||
| ->from(Card::class, 'c') | ||
| ->select(new Func('NEW ' . DtoWithEnum::class, ['c.suit'])) | ||
| ->getQuery() | ||
| ->getResult(); | ||
|
|
||
| $this->assertInstanceOf(Suit::class, $result[0]->suit); | ||
| $this->assertEquals(Suit::Clubs, $result[0]->suit); | ||
|
|
||
| $result = $this->_em->createQueryBuilder() | ||
| ->from(CardWithNullable::class, 'c') | ||
| ->select(new Func('NEW ' . DtoWithEnum::class, ['c.suit'])) | ||
| ->getQuery() | ||
| ->getResult(); | ||
|
|
||
| $this->assertNull($result[0]->suit); |
There was a problem hiding this comment.
These are actually two separate test cases. Please split them up.
There was a problem hiding this comment.
Done. 👍
As it was inspired by a test case above, I modified it as well.
romm
force-pushed
the
fix/enum-new-operator
branch
from
015cae5 to
3d12fca
Compare
|
Code looks good so far from my POV. Could you please write the tests using SQL for the NEW operator? Something like |
Using the `NEW` operator with the query builder now properly converts scalar values to native enums inside data transfer objects.
romm
force-pushed
the
fix/enum-new-operator
branch
from
3d12fca to
5d434c8
Compare
|
Sure 🙂 |
SenseException
approved these changes
Jul 31, 2022
derrabus
approved these changes
Aug 3, 2022
|
Cool. 🙂 |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 7, 2022
* 2.13.x: Address DBAL 3.4 deprecations (doctrine#9969) Improve phpdoc for ClassMetadataInfo (doctrine#9965) Fix build (doctrine#9964) fix: class normalisation test (doctrine#9966) Support native enum hydration when using `NEW` operator (doctrine#9936)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
NEWoperator with the query builder now properly convertsscalar values to native enums inside data transfer objects.