Require PHP 8.1 #9925
Merged
Require PHP 8.1 #9925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Jul 21, 2022
SenseException
approved these changes
Jul 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose to (once again) bump the minimum PHP version for the 3.0 branch to PHP 8.1.
Symfony did the same thing, mainly because of problems related to property types and preloading. I think, those problems will also apply to us, now that we add more and more native property types to the codebase. DBAL 4 will also require PHP 8.1 (doctrine/dbal#5543).
Among the installations that upgrade to our latest feature releases, PHP 8.1 has already reached a share of nearly 50%. PHP 8.0 on the other hand will only receive bugfixes for a few months.
Regarding features, I believe that
readonlyproperties will come in handy, especially for public properties on our attribute classes. Since making those propertiesreadonlyis technically a BC break, the 3.0 release would be a good opportunity for that change.