Show Expr::countDistinct() and Expr::concat() use variable-length argument lists

[craigfrancis]

Was PR #9909... somehow I committed to the 2.12.x branch, and have made a mess of the rebase.

---

The functions Expr::countDistinct() and Expr::concat() both use func_get_args() to accept a variable number of arguments.

They should explicitly show this via the "..." operator, which has been supported since PHP 5.6.

[greg0ire]

somehow I committed to the 2.12.x branch, and have made a mess of the rebase.

Don't commit anything to numbered branches, and create one new branch per MR, it will be easier to understand 😉

[greg0ire]

I experience the same build failure as you do with DBAL 4 on my own PR #9912

The build is broken, can't merge anything until it gets fixed.

[craigfrancis]

Yep, I normally do, but not been thinking today (currently 37°C)

[greg0ire]

🥵

[greg0ire]

Created #9913 for communication purposes

[greg0ire]

Thanks @craigfrancis !

[craigfrancis]

Thanks Grégoire, and sorry for making such a mess of a simple PR :-)