Avoid SQL assertions #9895
Merged
Avoid SQL assertions #9895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
avoid-sql-assertions
branch
from
30c0345 to
599fef6
Compare
|
I didn't rid the entire codebase from calls to |
derrabus
previously approved these changes
Jul 11, 2022
morozov
reviewed
Jul 12, 2022
doctrine/dbal is the component responsible for generating the queries. Let us make the test suite more robust by asserting that things work from a functional point of view.
greg0ire
force-pushed
the
avoid-sql-assertions
branch
from
599fef6 to
888a4a8
Compare
derrabus
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctrine/dbal is the component responsible for generating the queries.
Let us make the test suite more robust by asserting that things work
from a functional point of view.