Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parent classes in some events #9876

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Change parent classes in some events #9876

merged 1 commit into from
Jul 4, 2022

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Jul 2, 2022

Ref: #9875

*FlushEventArgs classes should extend ManagerEventArgs from doctrine/persistence to be able to use ManagerEventArgs for any persistance implementation.

OnClearEventArgs should extend from OnClearEventArgs from doctrine/persistence.

@franmomu
Change parent classes
eea5339 
*FlushEventArgs classes should extend ManagerEventArgs from
doctrine/persistence to be able to use ManagerEventArgs for any
persistance implementation.

OnClearEventArgs should extend from OnClearEventArgs from
doctrine/persistence.
@franmomu franmomu mentioned this pull request Jul 2, 2022
Open
3 tasks
@greg0ire greg0ire merged commit 68405f3 into doctrine:2.13.x Jul 4, 2022
@greg0ire
Copy link
Member

greg0ire commented Jul 4, 2022

Thanks @franmomu !

@franmomu franmomu deleted the extend_event_manager_args branch July 5, 2022 06:29
@derrabus derrabus added this to the 2.13.0 milestone Jul 25, 2022
@W0rma
Copy link
Contributor

W0rma commented Aug 8, 2022

The docs regarding the onFlush() event have not been updated yet (https://www.doctrine-project.org/projects/doctrine-orm/en/2.13/reference/events.html#onflush).

The example still uses OnFlushEventArgs::getEntityManager(). Should this be updated?

@franmomu franmomu mentioned this pull request Aug 8, 2022
Merged
greg0ire added a commit to greg0ire/doctrine-orm that referenced this pull request Jan 4, 2023
@greg0ire
Remove deprecated methods and classes
84e78b8 
This is a follow-up for doctrine#9876
@greg0ire greg0ire mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Deprecation
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@franmomu @greg0ire @W0rma @SenseException @derrabus