Remove dynamic property declarations #9683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Apr 26, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Apr 26, 2022
* 2.13.x: Remove dynamic property declarations (doctrine#9683) PHPStan 1.6.0 (doctrine#9682) Validate XML mapping against XSD file Document ORM drivers only really load ORM metadata Fix HydrationException::invalidDiscriminatorValue parameter type (doctrine#9676) Fix type on ClassMetadata discriminatorMap (doctrine#9675)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Apr 27, 2022
* 2.13.x: PHPStan 1.6.1 (doctrine#9688) Drop SymfonyStyle[listing] for sqls (doctrine#9679) Remove dynamic property declarations (doctrine#9683) PHPStan 1.6.0 (doctrine#9682) Validate XML mapping against XSD file Document ORM drivers only really load ORM metadata Fix HydrationException::invalidDiscriminatorValue parameter type (doctrine#9676) Fix type on ClassMetadata discriminatorMap (doctrine#9675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes test failures on PHP 8.2. Declaring properties dynamically by simply assigning a value to it now emits a runtime deprecation. All cases that I could find were in our test suite only and they were 100% mistakes: Either the property did not exist by accident or we assigned to wrong property or the assignment was just unnecessary.