Document QueryComponent array shape #9527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/document-query-component
branch
from
2fe440a to
76f3ee1
Compare
derrabus
force-pushed
the
improvement/document-query-component
branch
from
76f3ee1 to
69a2cf4
Compare
SenseException
approved these changes
Feb 24, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Feb 25, 2022
* 2.12.x: Document QueryComponent array shape (doctrine#9527) Improve templating Un-deprecate the current proxy mechanism (doctrine#9532) Remove unused methods Fix bug-doctrine#9536
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Feb 25, 2022
* 2.12.x: Document QueryComponent array shape (doctrine#9527) Improve templating Un-deprecate the current proxy mechanism (doctrine#9532) Remove unused methods Fix bug-doctrine#9536
n-e-m-a-nj-a
pushed a commit
to n-e-m-a-nj-a/orm
that referenced
this pull request
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently improving the types on SqlWalkers/TreeWalkers for 3.0. One issue I found was that the knowledge over the structure of the parser's internal
$queryComponentsarray was spread/copied over multiple classes.With this PR, I'm introducing a reusalbe Psalm type to streamline the type declarations.