Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types on CacheLogger implementations #9401

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

derrabus
Copy link
Member

Some backports from #9400:

  • More precise array types
  • Simplified the ternary expressions in StatisticsCacheLogger

@derrabus derrabus added this to the 2.12.0 milestone Jan 18, 2022
greg0ire
greg0ire previously approved these changes Jan 19, 2022
@derrabus derrabus force-pushed the types/cache-logger-backports branch from 432597b to 19dc457 Compare January 19, 2022 22:34
@derrabus derrabus merged commit f7822c7 into doctrine:2.12.x Jan 19, 2022
@derrabus derrabus deleted the types/cache-logger-backports branch January 19, 2022 23:29
derrabus added a commit to derrabus/orm that referenced this pull request Jan 20, 2022
* 2.12.x:
  Fix types on CacheLogger implementations (doctrine#9401)
  Rework some tests that use hardcoded DBAL mocks (doctrine#9404)
n-e-m-a-nj-a pushed a commit to n-e-m-a-nj-a/orm that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants