Remove the composer/package-versions-deprecated package
#9356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Jan 11, 2022
Seldaek
reviewed
Jan 11, 2022
derrabus
force-pushed
the
remove/package-versions
branch
from
4f325aa to
697e234
Compare
stof
approved these changes
Jan 11, 2022
|
Thanks @derrabus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see symfony/symfony#44726, doctrine/dbal#5078
With Composer's new plugin policy in mind, we should avoid dropping Composer plugins into an application's dependencies. I suggest to drop the
composer/package-versions-deprecateddependency and rely on Composer's runtime API instead.The consequence would be that people who are still on Composer 1 won't be able to upgrade the ORM anymore. Then again, at this point of time, there really should not be a reason anymore to use Composer 1.