-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessing private properties and methods from the same class is forbidden #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsavmic
force-pushed
the
patch-1
branch
2 times, most recently
from
January 1, 2022 19:33
8dbf940
to
057df98
Compare
SenseException
requested changes
Jan 12, 2022
docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst
Outdated
Show resolved
Hide resolved
docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst
Outdated
Show resolved
Hide resolved
docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst
Show resolved
Hide resolved
docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst
Outdated
Show resolved
Hide resolved
…dden Resolves issue doctrine/common#934 Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst Co-authored-by: Claudio Zizza <[email protected]> Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst Co-authored-by: Claudio Zizza <[email protected]> Fix review issues
SenseException
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the content and need another pair of eyes.
derrabus
approved these changes
Jan 17, 2022
derrabus
added a commit
that referenced
this pull request
Jan 18, 2022
* Expose enumType to DBAL to make native DB Enum possible (#9382) * Accessing private properties and methods from the same class is forbidden (#9311) Resolves issue doctrine/common#934 Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst Co-authored-by: Claudio Zizza <[email protected]> Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst Co-authored-by: Claudio Zizza <[email protected]> Fix review issues * Update baselines for DBAL 3.3 (#9393) Co-authored-by: Vadim Borodavko <[email protected]> Co-authored-by: olsavmic <[email protected]>
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 18, 2022
* 2.12.x: Deprecate MultiGetRegion (doctrine#9397) Fix type on loadCacheEntry (doctrine#9398) Update baselines for DBAL 3.3 (doctrine#9393) Accessing private properties and methods from the same class is forbidden (doctrine#9311) Expose enumType to DBAL to make native DB Enum possible (doctrine#9382)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves doctrine/common#934